Groups UI revision #1959
Merged
Groups UI revision #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinapurapu
requested review from
adfost,
bexsoft,
cniackz,
dvaldivia,
kaankabalak,
prakashsvmx and
ravindk89
prakashsvmx
reviewed
May 6, 2022
prakashsvmx
reviewed
May 6, 2022
prakashsvmx
previously approved these changes
May 6, 2022
ravindk89
previously approved these changes
May 6, 2022
Contributor
ravindk89
left a comment
ravindk89
left a comment
There was a problem hiding this comment.
This looks great, thank you
Co-authored-by: Prakash Senthil Vel <[email protected]>
Co-authored-by: Prakash Senthil Vel <[email protected]>
dvaldivia
previously approved these changes
May 6, 2022
dvaldivia
approved these changes
May 6, 2022
ravindk89
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from https://github.com/minio/console/issues/1932 , removes Options heading from table wrapper, changes to a selector based delete, adds EditIcon to highlight that rows can be clicked to view group details, adds Assign Policy button to allow policy assignment directly from groups screen.